Skip to content

Show exception message while ng starts - #6984

Merged
hansl merged 1 commit into
angular:masterfrom
rwoloszyn:show_exception_message
Jul 14, 2017
Merged

Show exception message while ng starts#6984
hansl merged 1 commit into
angular:masterfrom
rwoloszyn:show_exception_message

Conversation

@rwoloszyn

@rwoloszyn rwoloszyn commented Jul 14, 2017

Copy link
Copy Markdown
Contributor

There are plenty of reported error such as "" package was not properly installed."
which in most cases or all of them are connected with missing packages.

at Object.<anonymous> (/home/rafal/.npm-global/lib/node_modules/@angular/cli/node_modules/@ngtools/webpack/src/index.js:14:11) at Module._compile (module.js:570:32) at Object.Module._extensions..js (module.js:579:10) at Module.load (module.js:487:32) at tryModuleLoad (module.js:446:12) at Function.Module._load (module.js:438:3) at Module.require (module.js:497:17) at require (internal/module.js:20:19) at Object.<anonymous> (/home/rafal/.npm-global/lib/node_modules/@angular/cli/tasks/eject.js:10:19) at Module._compile (module.js:570:32) at Object.Module._extensions..js (module.js:579:10) at Module.load (module.js:487:32) at tryModuleLoad (module.js:446:12) at Function.Module._load (module.js:438:3) at Module.require (module.js:497:17) at require (internal/module.js:20:19)

Angular CLI throws an error which say almost nothing. There are a lot of different solutions (reinstalling etc) across the Internet but in most cases it's not missing but missing dependencies. Those errors are thrown in exceptions.

@googlebot

googlebot commented Jul 14, 2017

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@rwoloszyn
rwoloszyn force-pushed the show_exception_message branch from 2a568ed to 8183a8d Compare July 14, 2017 20:31
@googlebot

googlebot commented Jul 14, 2017

Copy link
Copy Markdown

CLAs look good, thanks!

@hansl
hansl merged commit e481bcb into angular:master Jul 14, 2017
Brocco pushed a commit to Brocco/angular-cli that referenced this pull request Jul 20, 2017
@rwoloszyn @Brocco
fix(@ngtools/webpack): show exception message when cannot find compil…
adc69f0 
…er-cli (angular#6984)
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this pull request Apr 23, 2018
@rwoloszyn @dond2clouds
fix(@ngtools/webpack): show exception message when cannot find compil…
8408f22 
…er-cli (angular#6984)
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 12, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
IchordeDionysos pushed a commit to simpleclub-extended/angular-cli that referenced this pull request Jul 14, 2026
@awerlang @vicb
test(core): ngOnDestroy called before output events are detached (ang…
752edca 
…ular#9946)

closes angular#6984
closes angular#5436
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@hansl hansl hansl approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rwoloszyn @googlebot @hansl